Messages in this thread | | | From | Paul Moore <> | Subject | Re: [PATCH 4/9] Netlink: Use generic LSM hook | Date | Mon, 3 Mar 2008 18:33:27 -0500 |
| |
On Saturday 01 March 2008 2:56:22 pm Ahmed S. Darwish wrote: > Don't use SELinux exported selinux_get_task_sid symbol. > Use the generic LSM equivalent instead. > > Signed-off-by: Casey Schaufler <casey@schaufler-ca.com> > Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
Reviewed-by: Paul Moore <paul.moore@hp.com>
> --- > > diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c > index 1ab0da2..61fd277 100644 > --- a/net/netlink/af_netlink.c > +++ b/net/netlink/af_netlink.c > @@ -54,7 +54,6 @@ > #include <linux/mm.h> > #include <linux/types.h> > #include <linux/audit.h> > -#include <linux/selinux.h> > #include <linux/mutex.h> > > #include <net/net_namespace.h> > @@ -1239,7 +1238,7 @@ static int netlink_sendmsg(struct kiocb *kiocb, > struct socket *sock, NETLINK_CB(skb).pid = nlk->pid; > NETLINK_CB(skb).dst_group = dst_group; > NETLINK_CB(skb).loginuid = audit_get_loginuid(current); > - selinux_get_task_sid(current, &(NETLINK_CB(skb).sid)); > + security_task_getsecid(current, &(NETLINK_CB(skb).sid)); > memcpy(NETLINK_CREDS(skb), &siocb->scm->creds, sizeof(struct > ucred)); > > /* What can I do? Netlink is asynchronous, so that
-- paul moore linux security @ hp
| |