Messages in this thread | | | Date | Mon, 03 Mar 2008 10:51:05 -0800 (PST) | Subject | Re: [PATCH] Removing unneeded statement from tcp_ipv4.c | From | David Miller <> |
| |
From: Arnd Hannemann <hannemann@nets.rwth-aachen.de> Date: Mon, 03 Mar 2008 14:23:38 +0100
> - if (tmp_opt.saw_tstamp && !tmp_opt.rcv_tsval) { > + if (tmp_opt.saw_tstamp && !tmp_opt.rcv_tsval) > /* Some OSes (unknown ones, but I see them on web server, which > * contains information interesting only for windows' > * users) do not send their stamp in SYN. It is easy case. > * We simply do not advertise TS support. > */ > tmp_opt.saw_tstamp = 0; > - tmp_opt.tstamp_ok = 0; > - } > +
Please don't format it like this.
When there is a multi-line comment, you should still enclose the basic block in braces. It's unreadable otherwise.
| |