Messages in this thread | | | Date | Fri, 28 Mar 2008 20:15:28 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [-mm] Add an owner to the mm_struct (v2) |
| |
On Fri, 28 Mar 2008 16:22:48 +0530 Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> > How about changing this css_get()/css_put() from accounting against mm_struct > > to accouting against task_struct ? > > It seems simpler way after this mm->owner change. > > But the reason why we account the mem_cgroup is that we don't want the > mem_cgroup to be deleted. I hope you meant mem_cgroup instead of mm_struct. > Ah, my text was complicated.
Now, - css_get(memcgrp) is called at mm_struct initialization. - css_put(memcgrp) is called at mm_struct freeing.
How about - css_get(memcgrp) is called at task_struct initialization. - css_put(memcgrp) is called at task_struct freeing.
Because 1. we find mem_cgroup by mm->owner, after this. 2. generic group interface have exit() and clone() callback interface.
mem_cgroup will not be freed until rmdir(), anyway.
Thanks, -Kame
| |