Messages in this thread | | | Date | Thu, 27 Mar 2008 09:18:10 +0000 | From | Russell King <> | Subject | Re: [PATCH 1/3] Clocklib: add generic framework for managing clocks. |
| |
On Thu, Mar 27, 2008 at 10:06:23AM +0100, Haavard Skinnemoen wrote: > > + int users; > > Reference counting, probably need that too. > > > + unsigned long rate; > > This one is redundant. Use getrate() instead.
... which means a separate getrate() functions for every clock. Not really practical for PXA.
> > + int delay; > > Huh? A delay after enabling the clock? Why can't the enable() hook do > that if it's really necessary?
... which means a separate enable() function for each clock. The delay there has not a lot to do with the actual register you're frobbing, but the resy of the SoC. So, again, not really practical for PXA.
The result for PXA is a tradeoff between reducing the data size and increasing the text size, or increasing the data size and keeping the existing data size.
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of:
| |