lkml.org 
[lkml]   [2008]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] mmiotrace full patch, preview 2
Hi,

I may of course be wrong, but... Shouldn't the post_kmmio_handler(),
called from the die notifier chain, check for the DR_STEP condition?
This makes sure that the function is not called in the cases where the
source of the debug exception was not a single-stepping event. Though
I guess you'll also have other checks in place to notice that the
interrupt was not the one you were expecting. I guess a little extra
safety won't hurt though?

On Sun, Mar 9, 2008 at 3:40 PM, Pekka Paalanen <pq@iki.fi> wrote:
> +/*
> + * Interrupts are disabled on entry as trap1 is an interrupt gate
> + * and they remain disabled thorough out this function.
> + * This must always get called as the pair to kmmio_handler().
> + */
> +static int post_kmmio_handler(unsigned long condition, struct pt_regs *regs)
> +{
> + int ret = 0;
> + struct kmmio_context *ctx = &get_cpu_var(kmmio_ctx);

if (!(condition & DR_STEP))
return;


Vegard


\
 
 \ /
  Last update: 2008-03-28 00:17    [W:0.083 / U:4.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site