Messages in this thread | | | Date | Fri, 28 Mar 2008 00:13:48 +0100 | From | "Vegard Nossum" <> | Subject | Re: [RFC] mmiotrace full patch, preview 2 |
| |
Hi,
I may of course be wrong, but... Shouldn't the post_kmmio_handler(), called from the die notifier chain, check for the DR_STEP condition? This makes sure that the function is not called in the cases where the source of the debug exception was not a single-stepping event. Though I guess you'll also have other checks in place to notice that the interrupt was not the one you were expecting. I guess a little extra safety won't hurt though?
On Sun, Mar 9, 2008 at 3:40 PM, Pekka Paalanen <pq@iki.fi> wrote: > +/* > + * Interrupts are disabled on entry as trap1 is an interrupt gate > + * and they remain disabled thorough out this function. > + * This must always get called as the pair to kmmio_handler(). > + */ > +static int post_kmmio_handler(unsigned long condition, struct pt_regs *regs) > +{ > + int ret = 0; > + struct kmmio_context *ctx = &get_cpu_var(kmmio_ctx);
if (!(condition & DR_STEP)) return;
Vegard
| |