lkml.org 
[lkml]   [2008]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] pci: revert "PCI: remove transparent bridge sizing"


On Fri, 28 Mar 2008, Ivan Kokshaysky wrote:
>
> Sounds good to me. So here we go (completely untested, just for review).
[...]
> - /* The bridge resources are special, as their
> - size != alignment. Sizing routines return
> - required alignment in the "start" field. */
> - align = (resno < PCI_BRIDGE_RESOURCES) ? size : res->start;
> +
> + align = resource_alignment(res);
> + BUG_ON(!align);

Don't do the BUG_ON(). That would just cause a broken machine, and makes
it much harder to report this issue. BUG_ON() should be used only for
totally unfixable things.

In this case, the easy thing to do is to just return an error, possibly
with a printk() about bogus resources (ignoring it as a resource, the way
we do it in pdev_sort_resource()).

But other than that, the thing doesn't look horrible.

Linus


\
 
 \ /
  Last update: 2008-03-27 23:39    [W:0.149 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site