lkml.org 
[lkml]   [2008]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] test for NULL return from platform_get_resource() in ohci_hcd_sm501_drv_remove()
Date
On Friday 21 March 2008, Jesper Juhl wrote:
>
> platform_get_resource() may return null, so although it seems it will never
> do so here unless there's a bug elsewhere, it does no harm to be defensive
> and test.
>
> Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>

Acked-by: David Brownell <dbrownell@users.sourceforge.net>

(and cc the author of that code: Magnus Damm <magnus.damm@gmail.com>)

> ---
>
> ohci-sm501.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ohci-sm501.c b/drivers/usb/host/ohci-sm501.c
> index a970701..1ffc272 100644
> --- a/drivers/usb/host/ohci-sm501.c
> +++ b/drivers/usb/host/ohci-sm501.c
> @@ -199,7 +199,8 @@ static int ohci_hcd_sm501_drv_remove(struct platform_device *pdev)
> usb_put_hcd(hcd);
> dma_release_declared_memory(&pdev->dev);
> mem = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> - release_mem_region(mem->start, mem->end - mem->start + 1);
> + if (mem)
> + release_mem_region(mem->start, mem->end - mem->start + 1);
>
> /* mask interrupts and disable power */
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>




\
 
 \ /
  Last update: 2008-03-27 20:47    [W:0.040 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site