Messages in this thread | | | Date | Thu, 27 Mar 2008 00:54:03 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 1/2 v3] Driver for Freescale 8610 and 5121 DIU |
| |
On Tue, 25 Mar 2008 16:27:17 -0500 York Sun <yorksun@freescale.com> wrote:
> +#if defined(CONFIG_NOT_COHERENT_CACHE) > +unsigned int *coherence_data; > +phys_addr_t *coherence_data_phy; > +#endif
These identifiers are too general for use as global symbols. I'd suggest renaming them to diu_coherence_data and diu_coherence_data_phy. Or make them static - I didn't check.
I'll duck this version of the patches, as Scott's comments looked rather substantial.
| |