lkml.org 
[lkml]   [2008]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: sparc64 BUG: using smp_processor_id() in preemptible
From
From: Andrew Morton <akpm@linux-foundation.org>
Date: Wed, 26 Mar 2008 20:25:02 -0700

> On Wed, 26 Mar 2008 04:25:16 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
>
> > preempt_disable();
> >
> > + mp = &__get_cpu_var(mmu_gathers);
>
> that's an open-coded get_cpu_var().
>
> fwiw. Which isn't much, IMO. Sometimes it's nice to see things open-coded.

Good point, I might restructure that to use {get,put}_cpu_var().


\
 
 \ /
  Last update: 2008-03-27 07:37    [W:0.040 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site