Messages in this thread | | | Subject | Re: [patch] pci: revert "PCI: remove transparent bridge sizing" | From | Benjamin Herrenschmidt <> | Date | Thu, 27 Mar 2008 10:45:49 +1100 |
| |
On Thu, 2008-03-27 at 02:29 +0300, Ivan Kokshaysky wrote:
> Well, at this point (pdev_sort_resources call) bridge resource->start > has nothing to do with a bus address, it just a temporary storage for > required alignment, filled by sizing routines (and 0 is definitely > invalid here).
Allright, that sounds better then.
> I know, this is quite confusing, but I didn't want to add extra > fields to existing structures or create temporary per-bus trees... > But after pci_assign_resource() that resource can certainly be at 0, > depending on PCIBIOS_MIN_{IO,MEM} and free slots in the resource tree.
In fact, this is the resource assignment code, and PCIBIOS_MIN_* is set to non-0 for powerpc too so we don't try to assign things down at 0 anyway, so we don't have a problem. We only care about things at 0 that have already been put there by the firmware and that we decide not to reassign.
So I don't have any objection anymore.
Cheers, Ben.
| |