Messages in this thread | | | Date | Wed, 26 Mar 2008 07:40:45 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 01/10] x86_64: Cleanup non-smp usage of cpu maps v2 |
| |
* Mike Travis <travis@sgi.com> wrote:
> Cleanup references to the early cpu maps for the non-SMP configuration > and remove some functions called for SMP configurations only.
thanks, applied.
one observation:
> +#ifdef CONFIG_SMP > extern int x86_cpu_to_node_map_init[]; > extern void *x86_cpu_to_node_map_early_ptr; > +#else > +#define x86_cpu_to_node_map_early_ptr NULL > +#endif
Right now all these early_ptrs are in essence open-coded "early per-cpu", right? But shouldnt we solve that in a much cleaner way: by explicitly adding an early-per-cpu types and accessors, and avoid all that #ifdeffery?
Ingo
| |