Messages in this thread | | | Date | Wed, 26 Mar 2008 18:09:50 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 02/10] init: move setup of nr_cpu_ids to as early as possible v2 |
| |
* Mike Travis <travis@sgi.com> wrote:
> Ingo Molnar wrote: > > * Mike Travis <travis@sgi.com> wrote: > > > >> Move the setting of nr_cpu_ids from sched_init() to > >> setup_per_cpu_areas(), so that it's available as early as possible. > > > > hm, why not a separate call before setup_per_cpu_areas(), so that we can > > avoid spreading this from generic kernel into a bunch of architectures > > that happen to have their own version of setup_per_cpu_areas(): > > > >> 7 files changed, 43 insertions(+), 15 deletions(-) > > > > Ingo > > I had this before but I then discovered that an arch would increase > (and possible decrease) it's number of possible cpus in > setup_per_cpu_areas(). So I figured that setting nr_cpu_ids (and the > cpumask_of_cpu map) should be a side effect of setup_per_cpu_areas().
well, then why not do it shortly after setup_per_cpu_areas()? That still moves it earlier than sched_init() but doesnt export all this code and complexity toevery setup_per_cpu_areas() implementation. (which clearly didnt need this complexity before)
Ingo
| |