Messages in this thread | | | Date | Wed, 26 Mar 2008 09:11:51 -0700 | From | Mike Travis <> | Subject | Re: [PATCH 01/10] x86_64: Cleanup non-smp usage of cpu maps v2 |
| |
Ingo Molnar wrote: > * Mike Travis <travis@sgi.com> wrote: > >> Cleanup references to the early cpu maps for the non-SMP configuration >> and remove some functions called for SMP configurations only. > > thanks, applied. > > one observation: > >> +#ifdef CONFIG_SMP >> extern int x86_cpu_to_node_map_init[]; >> extern void *x86_cpu_to_node_map_early_ptr; >> +#else >> +#define x86_cpu_to_node_map_early_ptr NULL >> +#endif > > Right now all these early_ptrs are in essence open-coded "early > per-cpu", right? But shouldnt we solve that in a much cleaner way: by > explicitly adding an early-per-cpu types and accessors, and avoid all > that #ifdeffery? > > Ingo
I was thinking of something similar but had to put it on the back burner until we got to the point of being able to boot a kernel with NR_CPUS set to 4096. It should pop back up on the priority queue very soon... ;-)
Thanks! Mike
| |