lkml.org 
[lkml]   [2008]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/12] cpumask: reduce stack pressure from local/passed cpumask variables v2
Ingo Molnar wrote:
> * Mike Travis <travis@sgi.com> wrote:
>
>> Modify usage of cpumask_t variables to use pointers as much as
>> possible.
>
> hm, why is there no minimal patch against -git that does nothing but
> introduces the new pointer based generic APIs (without using them) -
> such as set_cpus_allowed_ptr(), etc.? Once that is upstream all the
> remaining changes can trickle one arch and one subsystem at a time, and
> once that's done, the old set_cpus_allowed() can be removed. This is far
> more manageable than one large patch.
>
> and the cpumask_of_cpu() change should be Kconfig based initially - once
> all arches have moved to it (or even sooner) we can remove that.
>
> Ingo

Yes, good idea! I'll see about dividing them up. Though 99% seems to
be in generic kernel code (kernel/sched.c is by far the biggest user.)

There is one function pointer in a struct that would need an additional entry
if we keep both interfaces.

Thanks,
Mike


\
 
 \ /
  Last update: 2008-03-26 16:57    [W:0.054 / U:2.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site