Messages in this thread | | | Date | Wed, 26 Mar 2008 11:25:14 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cleanups - formatting only |
| |
* David Miller <davem@davemloft.net> wrote:
> From: Ingo Molnar <mingo@elte.hu> > Date: Tue, 25 Mar 2008 14:17:08 +0100 > > > There can be fluctuations and artifacts, and obviously this is just > > another (arbitrary) static metric that has no forced relationship with > > real code quality - but in my experience it's surprisingly close to > > reality - closer than any other code metric i've seen. > > And yet you used it to claim that the sparc64 port is an > unmaintainable pile of poo.
i did not claim that at all, the checkpatch average of sparc64 is pretty good:
errors lines of code errors/KLOC arch/sparc64/ 1457 49785 29.2
Sparc64 is one of the cleanest architectures, in terms of average checkpatch.pl code-quality.
the list i generated is the '20 worst files' (out of 90 sparc64 files) those are the files in need of cleanups (according to that metric) - and a quick manual glance confirmed that impression.
Or is it your position that every single file in sparc64 is squeaky clean and that each of the 1457 cleanliness problems that checkpatch.pl reported there is bogus?
Ingo
| |