lkml.org 
[lkml]   [2008]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 019/148] include/asm-x86/cpufeature.h: checkpatch cleanups - formatting only

* Joe Perches <joe@perches.com> wrote:

> On Tue, 2008-03-25 at 16:30 +0100, Ingo Molnar wrote:
> > > +#define X86_FEATURE_REP_GOOD _CF(3, 16) /* rep microcode works well
> > > + * on this CPU */
> > that is crap too ...
>
> the _CF or the newly line-broken comment?

both :) Line-breaking in macros isnt done like that. And the _CF thing:

+#if defined _CF
+#undef _CF
+#endif
+#define _CF(word, bit) ((word) * 32 + (bit))

looks quite ugly - either we have such a macro in which case it should
be a generic define somewhere that doesnt override anything else, or we
shouldnt do it.

I also had to fix some other typos that broke the 64-bit build. I ended
up skipping the whole cpufeatures.h patch - could you please re-do and
re-send it?

Ingo


\
 
 \ /
  Last update: 2008-03-25 21:17    [W:0.083 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site