Messages in this thread | | | Subject | Re: [PATCH 2/2] time: xtime lock vs printk | From | Daniel Walker <> | Date | Mon, 24 Mar 2008 07:21:55 -0700 |
| |
On Mon, 2008-03-24 at 13:24 +0100, Peter Zijlstra wrote: > - printk(KERN_INFO "Time: %s clocksource has been installed.\n", > + /* > + * We're holding xtime lock and waking up klogd would deadlock > + * us on enqueue. Print without waking. > + */ > + printk_nowakeup(KERN_INFO "Time: %s clocksource has been > installed.\n", > clock->name);
It doesn't seem like there is a lot of potential for more xtime write lock holders to do printk's .. We could just remove this line, or move this printk into an __init ..
Daniel
| |