Messages in this thread | | | Date | Sun, 23 Mar 2008 21:56:41 -0700 (PDT) | Subject | Re: [PATCH,TRIVIAL] AF_UNIX, accept() and addrlen | From | David Miller <> |
| |
From: Samuel Thibault <samuel.thibault@ens-lyon.org> Date: Sat, 8 Mar 2008 02:23:21 +0000
> Accept and getpeername are supposed to return the amount of bytes > written in the returned address. However, on unnamed sockets, only > sizeof(short) is returned, while a 0 is put in the sun_path member. > This patch adds 1 for that additional byte. > > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
This change isn't correct. It's the fact that the length returned is sizeof(short) that tells the caller that the unix socket is unnamed.
We zero out the sun_path[0] member just to be polite and tidy.
You would break applications if you changed this, so marking this patch as "trivial" is extremely premature.
| |