lkml.org 
[lkml]   [2008]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cleanups - formatting only
From
From: Jiri Slaby <jirislaby@gmail.com>
Date: Sun, 23 Mar 2008 13:24:23 +0100

> On 03/23/2008 01:19 PM, David Miller wrote:
> > There are mountains of more useful stuff to be working on (much of it
> > automated, but unlike checkpatch work doesn't result in crap) rather
> > than 148 patches of checkpatch vomit.
> >
> > Fixing sparse warnings properly fixes real issues, whereas fixing
> > checkpatch stuff creates garbage 9 times out of 10.
>
> Yes, I agree with you in this.
>
> What I don't agree with is that it's useless. It may help track down some issues
> in yet prepared patch (it's checkpatch, not checkcode and it should be used in
> that manner).

I strongly disagree still.

Half the warnings I get when I have run checkpatch on things I've
written were crap.

It's an automaton, and that's why people like it. It tells you
exactly what to do, and people like to be able to turn their brains
off like that.


\
 
 \ /
  Last update: 2008-03-23 13:33    [W:0.218 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site