Messages in this thread | | | Date | Sun, 23 Mar 2008 14:47:43 +0300 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH] CDROM: use kmalloced buffers instead of buffers on stack |
| |
[Thomas Bogendoerfer - Sun, Mar 23, 2008 at 12:15:32PM +0100] | If cdrom commands are issued to a scsi drive in most cases the buffer | will be filled via dma. This leads to bad stack corruption on non coherent | platforms, because the buffers are neither cache line aligned nor is | the size a multiple of the cache line size. Using kmalloced buffers | avoids this. | | Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> | --- | | drivers/cdrom/cdrom.c | 274 ++++++++++++++++++++++++++++++++----------------- | 1 files changed, 181 insertions(+), 93 deletions(-) | [...]
Hi Thomas,
maybe would be better to use one memory pool instead?
- Cyrill -
| |