lkml.org 
[lkml]   [2008]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 4/5] cdrom: use list_head for cdrom_device_info list
2008/3/22, Jens Axboe <jens.axboe@oracle.com>:
> On Sat, Mar 22 2008, Akinobu Mita wrote:
> > Use list_head for cdrom_device_info list instead of opencoded
> > singly list handling.
>
>
> Looks good, but you don't seem to be initializing ->list anywhere. Did
> you test this?
>
> I'd suggest just adding an INIT_LIST_HEAD() before the list_add() in
> register_cdrom()

It seems that current list_add() implementation doesn't need
initalized new entry with/without CONFIG_DEBUG_LIST.
And the following change will show too many warnings with CONFIG_DEBUG_LIST.

Is it recommended to add an INIT_LIST_HEAD() before the list_add()?

Index: 2.6-git/lib/list_debug.c
===================================================================
--- 2.6-git.orig/lib/list_debug.c
+++ 2.6-git/lib/list_debug.c
@@ -8,6 +8,7 @@

#include <linux/module.h>
#include <linux/list.h>
+#include <linux/bug.h>

/*
* Insert a new entry between two known consecutive entries.
@@ -49,6 +50,7 @@ EXPORT_SYMBOL(__list_add);
*/
void list_add(struct list_head *new, struct list_head *head)
{
+ WARN_ON(!list_empty(new));
__list_add(new, head, head->next);
}
EXPORT_SYMBOL(list_add);

\
 
 \ /
  Last update: 2008-03-22 16:13    [W:0.076 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site