Messages in this thread |  | | Date | Sat, 22 Mar 2008 13:55:35 +0100 | From | Jens Axboe <> | Subject | Re: [PATCH 4/5] cdrom: use list_head for cdrom_device_info list |
| |
On Sat, Mar 22 2008, Akinobu Mita wrote: > Use list_head for cdrom_device_info list instead of opencoded > singly list handling.
Looks good, but you don't seem to be initializing ->list anywhere. Did you test this?
I'd suggest just adding an INIT_LIST_HEAD() before the list_add() in register_cdrom()
You also seem to remove the !cdi check, which would be an unrelated change.
-- Jens Axboe
|  |