[lkml]   [2008]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] firewire: fw-ohci: catch self_id_count == 0
Stefan Richter wrote:
> Stefan Richter wrote:
>> fw_core_handle_bus_reset() incorrectly relied on the assumption that
>> self_id_count > 0.
> Even though
> firewire: insist on successive self ID complete events
> firewire: fw-ohci: add self ID error check
> firewire: fw-ohci: catch self_id_count == 0
> didn't fix any of Jarod's weird setups, I plan on submitting these
> patches nevertheless (after 2.6.25) because they IMO fix real
> possibilities for panics in the topology code.

Agreed, they all looked valid and didn't cause any regressions in my own
prodding. So go ahead with all three:

Signed-off-by: Jarod Wilson <>

Jarod Wilson

 \ /
  Last update: 2008-03-23 04:51    [W:0.065 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site