lkml.org 
[lkml]   [2008]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] bonding: Fix sysfs attribute handling
Date
From
Andrew Morton <akpm@linux-foundation.org> wrote:

>On Fri, 21 Mar 2008 14:52:55 +0100 Libor Pechacek <lpechacek@suse.cz> wrote:
>
>> bonding: Fix sysfs attribute handling
>>
>> For bonding interfaces any attempt to read the sysfs directory contents after
>> module removal results in an oops. The fix is to release sysfs attributes
>> for the interfaces upon module unload.
>>
>> Signed-off-by: Libor Pechacek <lpechacek@suse.cz>
>> --
>> drivers/net/bonding/bond_main.c | 3 +--
>> 1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>> index 0942d82..33767d4 100644
>> --- a/drivers/net/bonding/bond_main.c
>> +++ b/drivers/net/bonding/bond_main.c
>> @@ -4528,8 +4528,7 @@ static void bond_free_all(void)
>> netif_tx_unlock_bh(bond_dev);
>> /* Release the bonded slaves */
>> bond_release_all(bond_dev);
>> - bond_deinit(bond_dev);
>> - unregister_netdevice(bond_dev);
>> + bond_destroy(bond);
>> }
>
>Is this also needed in 2.6.24.x?

Yes (I haven't tested it personally, but the affected code is
the same). I was going to forward this to stable when it was accepted
upstream. The oops is fairly straightforward to create:

# modprobe bonding
# cd /sys/class/net/bond0/bonding
# rmmod bonding
# ls

-J

---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com


\
 
 \ /
  Last update: 2008-03-23 02:15    [W:0.052 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site