Messages in this thread |  | | Date | Sat, 22 Mar 2008 19:56:01 +0100 | From | Jörn Engel <> | Subject | Re: [PATCH] 2/3 mtd: add support for flash on the SEGA Dreamcast Visual Memory Unit |
| |
On Sat, 22 March 2008 18:39:07 +0000, Adrian McMenamin wrote: > On Sat, 2008-03-22 at 19:32 +0100, Jörn Engel wrote: > > > Given that you have ignored most of my previous comments, NAK. > > Not good enough, frankly. What comments have I ignored? I didn't > implement your suggestion that a void* memory type become be32* because > it was totally inappropriate for a type that is passed in both be32 and > le32 and as u8.
Your argument would make sense if referring to a transport layer where some structure is just passed along as payload data. But you are dereferencing a structure. And instead of declaring a structure, you still do this: ((unsigned long *)sendbuf)[0] = cpu_to_be32(MAPLE_FUNC_MEMCARD); ((unsigned long *)sendbuf)[1] = cpu_to_be32(partition << 24 | num);
If that is a valid description of "appropriate" in your dictionary then we clearly don't speak the same language. Even your own suggestion to change the cast to (u32*) would have been an improvement.
> I'm sorry that you feel that way, but as you took the hump when I said > that this: > > "Possibly the big-endian annotations need to trickly though the layers > here as well." > > Isn't good english (and it's not) and asked you - twice - to explain > what you meant. I cannot accept your summary.
s/trickly/trickle/
I tried to help you by a) reviewing the code and b) even converting the function myself after deciding that you don't understand what I meant. Clearly this didn't work. And maybe the problem is me, either because my English is insufficient or I am a d***head. Quite possible.
But even if I am the problem, you should be able to understand somebody's review comments and act accordingly. If not, I have a really bad feeling about this. And I hope someone else has more patience than me, because this code still needs work.
Jörn
-- It is better to die of hunger having lived without grief and fear, than to live with a troubled spirit amid abundance. -- Epictetus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |