lkml.org 
[lkml]   [2008]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [SCSI] fix media change events for polled devices
From
Date
On Fri, 2008-03-21 at 17:13 -0400, Jeff Garzik wrote:
> James Bottomley wrote:
> > On Fri, 2008-03-21 at 17:04 -0400, Jeff Garzik wrote:
> >> James Bottomley wrote:
> >>> It's fixed, and nothing else is additionally broken by the current fix.
> >> Other than the newly-inconsistent, exported-to-userspace interface, ITYM.
> >
> > How is it newly inconsistent? It can still be used in the manner you
> > intended it, namely to tell if the CD supports AN or not. When we add
> > the new bit, we'll have to add a new file for it anyway.
>
> Previously, the events could be expected to be sent (or sent) in strict
> accordance with supported_events.

we don't publish supported_events; we publish a single file called
media_change. Right at the moment its meaning is I have a 1 if AN is
supported and 0 if it's not.

Before the fix, its meaning was 1 if AN is supported and 0 if it's not.

The file name now looks wrong ... it should probably be an_media_change
or something if we have to introduce a new file called poll_media_chage
to distinguish them ... but nothing's changed about the way it works.

> Now, you are essentially sending out-of-band events, because the
> receiver requested supported_events -- but is getting much more than that!
>
> You broke a fundamental assumption of the interface -- that
> supported_events accurately and fully represented all events sent via
> the new API.

Anyway, realistically, since no CD or DVD on the market today seems to
support the AHCI AN method, this argument is really moot ... we just
need polling to work.

James




\
 
 \ /
  Last update: 2008-03-21 22:51    [W:0.056 / U:1.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site