Messages in this thread Patch in this message | | | Date | Fri, 21 Mar 2008 20:32:46 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH REPOST] [3/3] Replace macro recursion with more conventional loop |
| |
On Fri, 21 Mar 2008, Andi Kleen wrote: > On Fri, Mar 21, 2008 at 06:07:55PM +0100, Thomas Gleixner wrote: > > On Tue, 11 Mar 2008, Andi Kleen wrote: > > > The early exception handlers are currently set up using a macro > > > recursion. Replace that with a standard loop. > > > > > > Noop patch, just a cleanup. > > > > Cleanups before code changes please. > > It relies on the earlier changes.
I just had a closer look. Your patch order makes sense. It's less noise that way due to the previous removal of the 3 users of the macro.
I applied the series with the following changes:
- Moved 3/3 before 2/3 to make it clear that this is a consecutive cleanup - Simplified 3/3 (patch below) - fixed the commit log of 3/3 so it points out why the cleanup is done
Btw, can you please add a "x86:" prefix to your subject lines ?
Thanks,
tglx --
The early exception handlers are currently set up using a macro recursion. There is only one user left. Replace the macro with a standard loop in place.
--- linux-2.6.orig/arch/x86/kernel/head_64.S +++ linux-2.6/arch/x86/kernel/head_64.S @@ -269,15 +269,12 @@ bad_address: .section ".init.text","ax" #ifdef CONFIG_EARLY_PRINTK -.macro early_idt_tramp i - movl $\i, %esi - jmp early_idt_handler -.endm .globl early_idt_handlers early_idt_handlers: i = 0 .rept NUM_EXCEPTION_VECTORS - early_idt_tramp i + movl $i, %esi + jmp early_idt_handler i = i + 1 .endr #endif
| |