lkml.org 
[lkml]   [2008]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: r-o bind in nfsd
From
Date
> > > And having the vfsmount available within vfs_...() functions means,
> > > that the mnt_want_write() check can be moved inside, which means that
> > > callers get simpler and less likely to be buggy. Those are all
> > > advantages IMO, regardless of any security module issues.
> >
> > Or we can introduce another set of exported functions (path_mkdir(),
> > ...), and leave vfs_...() alone. And then the only question is if
> > LSM's can live with ordering change.
>
> I really don't see the point of new helpers; especially since one doesn't
> have to _have_ vfsmount to use the old ones and since we don't have a lot
> of users of each of those to start with.

Traditionally we have syscalls, and nfsd. Both of them want the
security checks, and I think nfsd wants the read-only mount checking
as well, but I'm not entirely sure. Maybe we can handle that by just
making nfsd acquire a write-ref on the mount and keep it while it's
exported.

Then there's ecryptfs and unionfs, which probably need neither, but it
wouldn't hurt to do them anyway.

Still, even if there are only two callers, then moving stuff to up
doesn't make any sense. Passing down a struct path is free for the
syscall case, it doesn't consume any stack space or extra CPU. Do
please tell, why would that be such a bad thing?

Miklos


\
 
 \ /
  Last update: 2008-03-21 19:55    [W:0.055 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site