lkml.org 
[lkml]   [2008]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] IDE: fix ide.h compiler warning
Hello.

Bartlomiej Zolnierkiewicz wrote:

> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] ide: do complete DMA setup in ->init_dma method (take 2)

> * Make ide_hwif_setup_dma() return an error value.

> * Pass 'const struct ide_port_info *d' instead of 'unsigned long dmabase'
> to ->init_dma method and make it return an error value.

> * Rename ide_get_or_set_dma_base() to ide_pci_dma_base(),
> change ordering of its arguments and then export it.

> * Export ide_pci_set_master().

> * Do complete DMA setup inside ->init_dma method and update ->init_dma
> users accordingly.

> * Sanitize code for DMA setup in ide_init_port().

> v2:
> * Fix for CONFIG_BLK_DEV_IDEDMA_PCI=n configs
> (from Jiri Slaby <jirislaby@gmail.com>):

> Fix following compiler warning by returning EINVAL:

> In file included from ANYTHING-INCLUDING-IDE.H:45:
> include/linux/ide.h: In function ‘ide_hwif_setup_dma’:
> include/linux/ide.h:1022: warning: no return statement in function returning non-void

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-03-21 19:11    [W:0.050 / U:2.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site