lkml.org 
[lkml]   [2008]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [5/7] Readd rdmsrl_safe
On Fri, 21 Mar 2008, Andi Kleen wrote:

> On Fri, Mar 21, 2008 at 06:06:13PM +0100, Thomas Gleixner wrote:
> > On Wed, 12 Mar 2008, Andi Kleen wrote:
> > > RDMSR for 64bit values with exception handling.
> > >
> > > Makes it easier to deal with 64bit valued MSRs. The old 64bit code
> > > base had that too as checking_rdmsrl(), but it got dropped somehow.
> >
> > Yup, no users.
> >
> > > +#define rdmsrl_safe(msr,p) \
> > > + ({ int __err; *(p) = native_read_msr_safe(msr, &__err); __err; })
> > > +
> >
> > static inline please
>
> Well all of paravirt.h uses macros. I did the same for consistency.

consistency ?

> If you want inlines it would be better to just convert it all in one
> go (but please only after this patch was applied)

Of course. We don't want to burden work on your shoulders.

Thanks

tglx


\
 
 \ /
  Last update: 2008-03-21 19:01    [W:1.123 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site