lkml.org 
[lkml]   [2008]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/8] ptrace: arch_ptrace -ENOSYS return

* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> > The reason I took the approach I did instead is incrementalism. I
> > can't change that signature without breaking about 22 arch builds.
>
> Don't worry about the arch builds. If that's your main worry and
> reason for this, it's not worth it. Yes, ptrace changes, and yes, we
> may have arch issues, but no, it's not that big of a deal. Just break
> them.
>
> Make sure x86[-64] works, and make sure that other architectures *can*
> work (and explain it on linux-arch) when you have to fix something up,
> but ptrace is a blip on the radar for people, it's not going to be a
> huge issue.

for a long time all the nice but intrusive utrace improvements from
Roland had this big adoption barrier. So Roland went around that and
with a lot of effort he made it optional, incremental and per arch, so
that we could try it on x86 and merge it upstream.

Now that we see how cleaner it is and that it actually was an almost
regression-free endevour on x86 (we had 2 regressions so far, both fixed
- which is an amazing feat for such wide changes IMO), i very much agree
that we should just do the "rest" of this in one big step.

it's a bit of a chicken & egg problem for such changes. If it breaks
architectures it gets dropped out of -mm - even though 90% of our
developers, 95% of our testers and 99% of our active users are using x86
only.

but in general, prototyping something on a single architecture in the
first step is OK - and maybe even the first merge is OK. But once it has
been proven on the most tested Linux platform that we have (and there's
no blatant x86-ism in it), there's no reason not to mandate it.

Ingo


\
 
 \ /
  Last update: 2008-03-21 16:11    [W:0.047 / U:1.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site