Messages in this thread | | | Date | Fri, 21 Mar 2008 12:50:29 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] Arch: x86_32, fix fault_msg nul termination |
| |
* Jiri Slaby <jirislaby@gmail.com> wrote:
> The fault_msg text is not explictly nul terminated now in startup > assembly. Do so by converting .ascii to .asciz.
thanks Jiri, applied.
> fault_msg: > - .ascii \ > + .asciz \ > /* fault info: */ "BUG: Int %d: CR2 %p\n" \ > /* pusha regs: */ " EDI %p ESI %p EBP %p ESP %p\n" \ > " EBX %p EDX %p ECX %p EAX %p\n" \
i guess in practice we were saved by a NIL following this string, but there's no guarantee indeed.
Ingo
| |