Messages in this thread | | | Subject | Re: [patch 3/8] mm: rotate_reclaimable_page() cleanup | From | Miklos Szeredi <> | Date | Tue, 18 Mar 2008 12:56:34 +0100 |
| |
> > -int rotate_reclaimable_page(struct page *page) > > +void rotate_reclaimable_page(struct page *page) > > { > > - struct pagevec *pvec; > > - unsigned long flags; > > - > > - if (PageLocked(page)) > > - return 1; > > - if (PageDirty(page)) > > - return 1; > > - if (PageActive(page)) > > - return 1; > > - if (!PageLRU(page)) > > - return 1; > > Might be me, but I find the above easier to read than > > > + if (!PageLocked(page) && !PageDirty(page) && !PageActive(page) && > > + PageLRU(page)) { > >
Matter of taste, returning from a middle of a function is generally to be avoided (unless not). Anyway, this is just a side effect of the main cleanup, so I think I'm entitled to choose the style I prefer ;)
Miklos
| |