lkml.org 
[lkml]   [2008]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [11/18] Fix alignment bug in bootmem allocator
On Mon, Mar 17, 2008 at 12:41 AM, Andi Kleen <andi@firstfloor.org> wrote:
> > when node_boot_start is 512M alignment, and align is 1024M, offset
> > could be 512M. it seems
> > i = ALIGN(i, incr) need to do sth with offset...
>
> It's possible that there are better fixes for this, but at least
> my simple patch seems to work here. I admit I was banging my
> head against this for some time and when I did the fix I just
> wanted the bug to go away and didn't really go for subtleness.
>
> The bootmem allocator is quite spaghetti in fact, it could
> really need some general clean up (although it's' not quite
> as bad yet as page_alloc.c)

i = ALIGN(i+offset, incr) - offset;

also the one in fail_block...

only happen when align is large than alignment of node_boot_start.

YH


\
 
 \ /
  Last update: 2008-03-17 08:57    [W:0.164 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site