lkml.org 
[lkml]   [2008]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] Bsd_acct: using task_struct->tgid is not right in pid-namespaces
On 03/17, Pavel Emelyanov wrote:
>
> In case we're accounting from a sub-namespace,

Offtopic. Bsd-accounting is system wide. I can't understand what should
we do if multiple namespaces do acct_on().

> the tgids
> reported will not refer to the right namespace.

I think the patch is correct, but let's suppose that a sub-namespace does
accounting, and the task from the parent namespace exits. With this patch
we report ac.ac_pid == 0, which is a bit strange. But the question is,
should we see the tasks from the parent namespace at all?

Perhaps, the task shouldn't account itself if it doesn't "belong" to
acct_globals.ns ? In that case we don't need other changes to figure
out ac.ac_pid/ac_ppid.

Better yet, perhaps acct_on() should be forbidden for non-root ns?

(but the patch itself is correct afaics)

Oleg.



\
 
 \ /
  Last update: 2008-03-17 18:55    [W:0.042 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site