Messages in this thread | | | Date | Mon, 17 Mar 2008 08:09:25 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH 2.6.25] - Fix transmit queue stop mechanism |
| |
Divy Le Ray wrote: > From: Divy Le Ray <divy@chelsio.com> > > The last change in the Tx queue stop mechanism opens a window > where the Tx queue might be stopped after pending credits > returned. > > Tx credits are returned via a control message generated by the HW. > It returns tx credits on demand, triggered by a completion bit > set in selective transmit packet headers. > > The current code can lead to the Tx queue stopped > with all pending credits returned, and the current frame > not triggering a credit return. The Tx queue will then never be > awaken. > > The driver could alternatively request a completion for packets > that stop the queue. It's however safer at this point to go back > to the pre-existing behaviour. > > Signed-off-by: Divy Le Ray <divy@chelsio.com> > --- > > drivers/net/cxgb3/sge.c | 12 +++++++++--- > 1 files changed, 9 insertions(+), 3 deletions(-)
applied -- please include "cxgb3: " prefix in your subject line next time.
See http://linux.yyz.us/patch-format.html for more info.
Jeff
| |