Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 3/3] KEYS: Make the keyring quotas controllable through /proc/sys | Date | Fri, 14 Mar 2008 11:46:08 +0000 |
| |
Andrew Morton <akpm@linux-foundation.org> wrote:
> > +#ifdef CONFIG_SYSCTL > > +extern ctl_table key_sysctls[]; > > +#endif > > I've been going around telling people to not bother with the ifdefs here. > Upside: looks nicer. Downside: defers the build error from compile-time to > link-time.
Should this extern actually be in include/linux/sysctl.h? I'd rather not put it in include/linux/key.h as that means that key.h must include sysctl.h just to get a definition of ctl_table. Conversely, however, sysctl.h doesn't need to include key.h to include the above extern.
David
| |