Messages in this thread | | | Date | Fri, 14 Mar 2008 15:20:18 +0000 | From | "Jan Beulich" <> | Subject | Re: [PATCH] x86: simplify sync_test_bit() |
| |
>#define sync_test_bit(nr, addr) test_bit(nr, addr) > >would be better, but seems reasonable to me. Or even an inline for >consistency.
I'm usually intentionally using just the names, without parameters and not as inline, in such alias definitions so that in case the name gets used as a function pointer (arguably unlikely here) there's not going to be any missing definition or duplicate function instantiation. But from a functionality point of view, either of the alternatives you suggest is of course as good.
Jan
| |