Messages in this thread Patch in this message | | | Date | Thu, 13 Mar 2008 16:06:06 -0700 | From | Andrew Morton <> | Subject | Re: [patch 2.6.25-rc5 2/2] gpiochip_reserve() |
| |
On Thu, 13 Mar 2008 14:52:21 -0800 David Brownell <david-b@pacbell.net> wrote:
> +int __init __must_check gpiochip_reserve(int start, int ngpio)
I applaud the addition of __msut_check to a newly-added function of this kind, but we usually only add the tag to the declaration, not to the definition as well.
Not a lot of thought went into this, but we might as well be consistent.
--- a/drivers/gpio/gpiolib.c~gpiochip_reserve-fix +++ a/drivers/gpio/gpiolib.c @@ -121,7 +121,7 @@ static int gpiochip_find_base(int ngpio) * to mark a range of gpios as unavailable for dynamic gpio number allocation, * for example because its driver support is not yet loaded. */ -int __init __must_check gpiochip_reserve(int start, int ngpio) +int __init gpiochip_reserve(int start, int ngpio) { int ret = 0; unsigned long flags;
| |