Messages in this thread Patch in this message | | | Date | Thu, 13 Mar 2008 23:58:37 +0100 | From | Roel Kluin <> | Subject | Re: [PATCH] logical-bitwise & confusion in se401_init() |
| |
Rik van Riel wrote: > On Thu, 13 Mar 2008 16:51:29 +0100 > Roel Kluin <12o3l@tiscali.nl> wrote: > >> - if (!cp[2] && SE401_FORMAT_BAYER) { >> + if (!cp[2] & SE401_FORMAT_BAYER) { >> err("Bayer format not supported!"); >> return 1; >> } > > Would it be better to put in some additional parenthesis? > > if (!(cp[2] & SE401_FORMAT_BAYER)) { > yes of course, thanks for catching that. --- logical-bitwise & confusion
Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/drivers/media/video/se401.c b/drivers/media/video/se401.c index d5d7d6c..9e8b521 100644 --- a/drivers/media/video/se401.c +++ b/drivers/media/video/se401.c @@ -1279,7 +1279,7 @@ static int se401_init(struct usb_se401 *se401, int button) rc=se401_sndctrl(0, se401, SE401_REQ_GET_HEIGHT, 0, cp, sizeof(cp)); se401->cheight=cp[0]+cp[1]*256; - if (!cp[2] && SE401_FORMAT_BAYER) { + if (!(cp[2] & SE401_FORMAT_BAYER)) { err("Bayer format not supported!"); return 1; }
| |