Messages in this thread | | | Date | Tue, 11 Mar 2008 18:51:38 -0700 | From | Jeremy Fitzhardinge <> | Subject | Re: 2.6.25-rc5-mm1 (paravirt/vsmp/no PCI) |
| |
Ravikiran G Thirumalai wrote: > Would anyone have objection to have PARAVIRT depend on PCI, since the > vsmp paravirt bits depend on PCI cfg space to determine if the system is > vsmp? If not, this patch would suffice. >
NAK. Xen doesn't depend on PCI at all. Why not make VSMP depend on PCI? Then you could put something like:
#ifdef CONFIG_X86_VSMP extern void vsmp_init(void); extern int is_vsmp_box(void); #else static inline void vsmp_init(void) { }
static inline int is_vsmp_box(void) { return 0; } #endif
in an appropriate header.
Hm, looks like arch/x86/kernel/Makefile should be
obj-$(CONFIG_X86_VSMP) += vsmp_64.o
rather than making it depend directly on CONFIG_PARAVIRT.
J
| |