Messages in this thread | | | Date | Tue, 11 Mar 2008 21:11:27 +0300 | From | Oleg Nesterov <> | Subject | Re: [PATCH 5/6] signals: unify send_sigqueue/send_group_sigqueue completely |
| |
On 03/10, Roland McGrath wrote: > > Looks fine. But I'd like a comment on the "ret = 1" case making > explicit what that magic return case is for and why the value > matters (to posix_timer_event).
Well, currently this helper is solely used by posix_timer_event(), but despite the fact it has BUG_ON(!SI_TIMER) it is quite generic, there were patches which used it for aio.
So I don't think we should document the interaction with posix timers, but OK, I'll send a small comment update.
Oleg.
| |