Messages in this thread | | | Date | Tue, 11 Mar 2008 10:56:31 +0100 | From | Ingo Molnar <> | Subject | Re: [RFC/PATCH] x86: Optimize find_next_(zero_)bit for small constant-size bitmaps |
| |
* Alexander van Heukelum <heukelum@mailshack.com> wrote:
> x86: Optimize find_next_(zero_)bit for small constant-size bitmaps
thanks, looks nice, except for a small detail:
> +#ifdef CONFIG_GENERIC_FIND_NEXT_BIT > +unsigned long __find_next_bit(const unsigned long *addr, > + unsigned long size, unsigned long offset); > + > +static __always_inline unsigned long > +find_next_bit(const unsigned long *addr, unsigned long size, > + unsigned long offset)
> +#endif /* CONFIG_GENERIC_FIND_NEXT_BIT */
there should be an #else here i think, which maps find_next_bit to __find_next_bit / etc.
small syntactic nit:
> +unsigned long __find_next_bit(const unsigned long *addr, > + unsigned long size, unsigned long offset);
should be explicitly "extern", so that we see that it's a prototype declaration.
Ingo
| |