Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH] x86: Simplify cpu_idle_wait | Date | Fri, 8 Feb 2008 11:28:48 +0100 |
| |
> - set_cpus_allowed(current, tmp); > + smp_mb(); > + /* kick all the CPUs so that they exit out of pm_idle */ > + smp_call_function(do_nothing, NULL, 0, 0);
I think the last argument (wait) needs to be 1 to make sure it is synchronous (for 32/64) Otherwise the patch looks great.
-Andi
| |