Messages in this thread | | | From | Jarod Wilson <> | Subject | Re: [PATCH 11/9] firewire: fw-sbp2: enforce a retry of __scsi_add_device if bus generation changed | Date | Fri, 8 Feb 2008 13:54:23 -0500 |
| |
On Wednesday 06 February 2008 04:09:47 pm Stefan Richter wrote: > fw-sbp2 is unable to reconnect while performing __scsi_add_device > because there is only a single workqueue thread context available for > both at the moment. This should be fixed eventually. > > Until then, take care that __scsi_add_device does not return success > even though the SCSI high-level driver probing failed (sd READ_CAPACITY > and friends) due to bus reset. The trick to do so is to use a different > error indicator in the command completion as long as __scsi_add_device > did not return. > > An actual failure of __scsi_add_device is easy to handle, but an > incomplete execution of __scsi_add_device with an sdev returned would > remain undetected and leave the SBP-2 target unusable. > > Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> > --- > > Jarod, does this work like I assume and fixes your setup of two OXFW911 > based disks?
Well, it results in the dmesg spew saying "sd 6:0:0:0: [sdc] Result: hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK,SUGGEST_OK" -- i.e., DID_NO_CONNECT instead of DID_BUS_BUSY, but other than that, no change in behavior, sdc remains unusable just as before.
-- Jarod Wilson jwilson@redhat.com
| |