Messages in this thread | | | Date | Thu, 7 Feb 2008 19:28:54 -0700 | From | Grant Grundler <> | Subject | Re: [PATCH] Change pci_raw_ops to pci_raw_read/write |
| |
On Thu, Feb 07, 2008 at 11:36:18AM -0500, Tony Camuso wrote: > Arjan van de Ven wrote: >> On Thu, 07 Feb 2008 10:54:05 -0500 >> Tony Camuso <tcamuso@redhat.com> wrote: >>> Matthew, >>> >>> Perhaps I missed it, but did you address Yinghai's concerns? >>> >>> Yinghai Lu wrote: >>>> On Jan 28, 2008 7:03 PM, Matthew Wilcox <matthew@wil.cx> wrote: >>>>> -int pci_conf1_write(unsigned int seg, unsigned int bus, >>>>> +static int pci_conf1_write(unsigned int seg, unsigned int bus, >>>>> unsigned int devfn, int reg, int len, >>>>> u32 value) >>>> any reason to change pci_conf1_read/write to static? >>>> >> nothing should use these directly. So static is the right answer ;) > > Agreed. Thanks, Arjan. > > Matthew, > What about the ATA_RAM addition to Kconfig? Was it accidental, > or intended? If intended, how is it related?
AFAICT, it looks accidental. I can't see how it's related. He should be back online next week and can answer for himself.
hth, grant
| |