lkml.org 
[lkml]   [2008]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] udf: udf_get_block, inode_bmap - remove unneeded checks
On Sun 03-02-08 19:36:06, marcin.slusarz@gmail.com wrote:
> block cannot be less than 0, because it's sector_t,
> so remove unneeded checks
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Cc: Jan Kara <jack@suse.cz>
Acked-by: Jan Kara <jack@suse.cz>

Honza
> ---
> fs/udf/inode.c | 12 ------------
> 1 files changed, 0 insertions(+), 12 deletions(-)
>
> diff --git a/fs/udf/inode.c b/fs/udf/inode.c
> index c2d0477..531443d 100644
> --- a/fs/udf/inode.c
> +++ b/fs/udf/inode.c
> @@ -323,9 +323,6 @@ static int udf_get_block(struct inode *inode, sector_t block,
>
> lock_kernel();
>
> - if (block < 0)
> - goto abort_negative;
> -
> iinfo = UDF_I(inode);
> if (block == iinfo->i_next_alloc_block + 1) {
> iinfo->i_next_alloc_block++;
> @@ -347,10 +344,6 @@ static int udf_get_block(struct inode *inode, sector_t block,
> abort:
> unlock_kernel();
> return err;
> -
> -abort_negative:
> - udf_warning(inode->i_sb, "udf_get_block", "block < 0");
> - goto abort;
> }
>
> static struct buffer_head *udf_getblk(struct inode *inode, long block,
> @@ -2081,11 +2074,6 @@ int8_t inode_bmap(struct inode *inode, sector_t block,
> int8_t etype;
> struct udf_inode_info *iinfo;
>
> - if (block < 0) {
> - printk(KERN_ERR "udf: inode_bmap: block < 0\n");
> - return -1;
> - }
> -
> iinfo = UDF_I(inode);
> pos->offset = 0;
> pos->block = iinfo->i_location;
> --
> 1.5.3.7
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR


\
 
 \ /
  Last update: 2008-02-05 16:33    [W:0.112 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site