lkml.org 
[lkml]   [2008]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: Commit f06e4ec breaks vmware

* Jan Engelhardt <jengelh@computergmbh.de> wrote:

> sad to say, but f06e4ec... breaks booting the kernel in vmware
> (bisected). Booting just stops after
>
> Checking for 'hlt' instruction...
>
> commit f06e4ec1c15691b0cfd2397ae32214fa36c90d71
> Author: Ingo Molnar <mingo@elte.hu>
> Date: Wed Jan 30 13:32:39 2008 +0100
>
> x86: read_tsc sync
>
> make native_read_tsc() always non-speculative.

could you send us the /proc/cpuinfo data of the guest CPU?

if latest -git still fails, does the patch below solve the problem?

Ingo

---
include/asm-x86/system.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux-x86.q/include/asm-x86/system.h
===================================================================
--- linux-x86.q.orig/include/asm-x86/system.h
+++ linux-x86.q/include/asm-x86/system.h
@@ -407,8 +407,7 @@ void default_idle(void);
*/
static inline void rdtsc_barrier(void)
{
- alternative(ASM_NOP3, "mfence", X86_FEATURE_MFENCE_RDTSC);
- alternative(ASM_NOP3, "lfence", X86_FEATURE_LFENCE_RDTSC);
+ smp_mb();
}

#endif

\
 
 \ /
  Last update: 2008-02-04 12:55    [W:0.059 / U:1.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site