Messages in this thread Patch in this message | | | Date | Mon, 4 Feb 2008 12:51:44 +0100 | From | Ingo Molnar <> | Subject | Re: Commit f06e4ec breaks vmware |
| |
* Jan Engelhardt <jengelh@computergmbh.de> wrote:
> sad to say, but f06e4ec... breaks booting the kernel in vmware > (bisected). Booting just stops after > > Checking for 'hlt' instruction... > > commit f06e4ec1c15691b0cfd2397ae32214fa36c90d71 > Author: Ingo Molnar <mingo@elte.hu> > Date: Wed Jan 30 13:32:39 2008 +0100 > > x86: read_tsc sync > > make native_read_tsc() always non-speculative.
could you send us the /proc/cpuinfo data of the guest CPU?
if latest -git still fails, does the patch below solve the problem?
Ingo
--- include/asm-x86/system.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Index: linux-x86.q/include/asm-x86/system.h =================================================================== --- linux-x86.q.orig/include/asm-x86/system.h +++ linux-x86.q/include/asm-x86/system.h @@ -407,8 +407,7 @@ void default_idle(void); */ static inline void rdtsc_barrier(void) { - alternative(ASM_NOP3, "mfence", X86_FEATURE_MFENCE_RDTSC); - alternative(ASM_NOP3, "lfence", X86_FEATURE_LFENCE_RDTSC); + smp_mb(); } #endif
| |