lkml.org 
[lkml]   [2008]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: 2.6.24-mm1: module params broken
    On Mon, 4 Feb 2008 21:56:54 +0000 (GMT)
    Hugh Dickins <hugh@veritas.com> wrote:

    > Please chuck out:
    > add-new-string-functions-strict_strto-and-convert-kernel-params-to-use-them.patch
    > (along with Randy's perfectly reasonable -fix.patch).
    >
    > So predictable that it would just disable loading modules with params:
    > Feb 4 13:17:02 blonde kernel: thinkpad_acpi: `1' invalid for parameter `experimental'
    >
    > Maybe it's something as simple as a trailing whitespace issue,
    > I haven't looked, would prefer the originator to do so.
    > openSUSE 10.3 if that makes any difference.
    >

    Takashi found a bug in it:

    --- a/lib/vsprintf.c~add-new-string-functions-strict_strto-and-convert-kernel-params-to-use-them-fix-2
    +++ a/lib/vsprintf.c
    @@ -234,7 +234,7 @@ int strict_strto##type(const char *cp, u
    if (ret != 0) \
    *res = -(*res); \
    } else \
    - ret = strict_strtou##type(cp+1, base, res); \
    + ret = strict_strtou##type(cp, base, res); \
    \
    return ret; \
    } \
    _
    and I was very bad and didn't immediately prepare and upload the fix and
    hence probably wasted a lot of your time, for which I apologise. In my
    defense, it was 4:00AM Sunday and I had lost eye control by then.

    Does that fix fix it? If not: patch overboard.


    \
     
     \ /
      Last update: 2008-02-05 00:09    [W:4.486 / U:0.656 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site