lkml.org 
[lkml]   [2008]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Remove unneeded code in sys_getpriority
Date
On Sunday 03 February 2008 04:04, Rabin Vincent wrote:
> This check is not required because the condition is always true.
> ...
> - if (niceval > retval)
> - retval = niceval;
> + retval = 20 - task_nice(p);

Thats surely correct, but on the other hand currently those
case blocks are quite independet of their possition/could easily
be rearranged now .. or think of another case is put ahead.
Then this could mess up things.

Thanks,
Frank


\
 
 \ /
  Last update: 2008-02-03 10:57    [W:0.040 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site