Messages in this thread | | | From | Frank Seidel <> | Subject | Re: [PATCH] Remove unneeded code in sys_getpriority | Date | Sun, 3 Feb 2008 10:54:45 +0100 |
| |
On Sunday 03 February 2008 04:04, Rabin Vincent wrote: > This check is not required because the condition is always true. > ... > - if (niceval > retval) > - retval = niceval; > + retval = 20 - task_nice(p);
Thats surely correct, but on the other hand currently those case blocks are quite independet of their possition/could easily be rearranged now .. or think of another case is put ahead. Then this could mess up things.
Thanks, Frank
| |